OpenFreeEnergy / OpenFreeEnergy/ExampleNotebooks

TKY2 Result failure with gather

Open
#141 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
70
Forks
15
Avg merge
10h 42m
Merged PRs (30d)
2

Description

/usr/local/lib/python3.10/site-packages/cinnabar/stats.py:207: RuntimeWarning: divide by zero encountered in scalar power
  F_matrix[i, j] = -df_ij[i, j] ** (-2)
/usr/local/lib/python3.10/site-packages/cinnabar/stats.py:208: RuntimeWarning: divide by zero encountered in scalar power
  F_matrix[j, i] = -df_ij[i, j] ** (-2)
/usr/local/lib/python3.10/site-packages/cinnabar/stats.py:228: RuntimeWarning: divide by zero encountered in scalar power
  z[i] += f_ij[i, j] * df_ij[i, j] ** (-2)
/usr/local/lib/python3.10/site-packages/cinnabar/stats.py:229: RuntimeWarning: divide by zero encountered in scalar power
  z[j] += f_ij[j, i] * df_ij[j, i] ** (-2)
/usr/local/lib/python3.10/site-packages/cinnabar/stats.py:228: RuntimeWarning: invalid value encountered in scalar add
  z[i] += f_ij[i, j] * df_ij[i, j] ** (-2)
/usr/local/lib/python3.10/site-packages/cinnabar/stats.py:229: RuntimeWarning: invalid value encountered in scalar add
  z[j] += f_ij[j, i] * df_ij[j, i] ** (-2)
Traceback (most recent call last):
  File "/usr/local/bin/openfe", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/openfecli/commands/gather.py", line 376, in gather
    writing_func(legs, writer, allow_partial)
  File "/usr/local/lib/python3.10/site-packages/openfecli/commands/gather.py", line 259, in _write_dg_mle
    f_i, df_i = mle(g, factor='calc_DDG')
  File "/usr/local/lib/python3.10/site-packages/cinnabar/stats.py", line 232, in mle
    Finv = np.linalg.pinv(F_matrix)
  File "/usr/local/lib/python3.10/site-packages/numpy/linalg/linalg.py", line 2022, in pinv
    u, s, vt = svd(a, full_matrices=False, hermitian=hermitian)
  File "/usr/local/lib/python3.10/site-packages/numpy/linalg/linalg.py", line 1681, in svd
    u, s, vh = gufunc(a, signature=signature, extobj=extobj)
  File "/usr/local/lib/python3.10/site-packages/numpy/linalg/linalg.py", line 121, in _raise_linalgerror_svd_nonconvergence
    raise LinAlgError("SVD did not converge")
numpy.linalg.LinAlgError: SVD did not converge

This is with https://github.com/OpenFreeEnergy/ExampleNotebooks/releases/download/april-2024/results_tyk2_transformations_openfe_1.0.0rc0_uc_2.tar.gz

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with the linked results archive, then start at openfecli/commands/gather.py in _write_dg_mle and follow the call into cinnabar/stats.py:mle. Investigate the divide-by-zero warnings and SVD failure; done means the gather path handles or clearly reports this input without the current unhandled exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.