One way to close the run viewer
Nobody has claimed this yet.
- Dominant language
- Elixir
- Stars
- 296
- Forks
- 86
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 50
Description
While reviewing #4984, Lucy noticed we now have two ways to stop viewing a run: the teardown that the run-following hook hands back, and the newer dedicated command on the history commands hook. They do exactly the same thing.
The cleaner end state she suggested: let the run-following hook own only the "connect and follow" side, and have the two places that still use its teardown (the full-screen IDE and the diagram) call the dedicated command instead. While we're there, the underlying store method could become a proper public command rather than an underscore-prefixed internal one exported through the hook.
Small cleanup, no behavior change expected. Deliberately kept out of #4984 to keep that PR's revert boundary clean.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the run-following hook, the history commands hook, and the teardown callers in the full-screen IDE and diagram. Confirm how the underlying store method is exposed, then switch those callers to the dedicated command and make the store method public; done means the duplicate teardown path is removed with no behavior change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elixir
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100