OpenFn / OpenFn/lightning

Existing input filters are broken in non UTC timezones

Open
#4,983 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

I am in timezone UTC+1 right now

Look closely at this image:

Image
  • The filter is set to only show dataclips created before 16:39
  • The list shows several dataclips created after 16:40

if I update the criteria to show dataclips created before 15:40 it shows this:

Image

Note that there is one dataclip created at 16:38 - which should be filtered out!

What's happening here is that my browser is showing times in my local timezone, UTC+1. So when it says 16:40 on my UI, it actually means 15:40 in the database.

When I pick 16:40 in the date picker, I think we need to internally adjust that time to match server time

Found while on prod 2.16.8

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the filter in a browser set to UTC+1, then trace how the date-picker value is converted before the dataclip query runs. Verify the result against the displayed local times and confirm that filtering before a selected time excludes later dataclips without changing UTC behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.