Pressing command+enter runs even when a the save & sync dialog is open
Open
Nobody has claimed this yet.
bug
- Dominant language
- Elixir
- Stars
- 296
- Forks
- 86
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 50
Description
- I had the Save & Sync dialog open
- I typed my commit message
- I wanted to submit the commit message via keystroke (i rarely use the mouse!)
- i pressed command+enter and it triggered "Save & Run", possibly losing my commit message and possible not syncing to github.
- the big rule here is (I think!) when a modal is open, other keystrokes shouldn't be active. Modals are full-focus interfaces.
We blur the rest of the app out, so keystrokes shouldn't be able to bypass the blur and access the rest of the app.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the keyboard shortcut handling for Save & Run and the focus behavior of the Save & Sync dialog. Reproduce the issue with Command+Enter while the dialog is open; done means the keystroke submits only the dialog action and cannot trigger Save & Run behind the modal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elixir
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100