OpenFn / OpenFn/lightning

UI makes it seem like concurrency settings work for sync-mode workflows

Open
#4,569 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

The default behaviour for lightning instance installs renders concurrency for workflows that use a sync-mode webhook trigger inert, but right now it the UI makes it look like you can set concurrency for those workflows.

Image

We should disable the workflow concurrency input when sync mode is enabled for that workflow trigger, or at least warn that given the current worker settings (hard to know, eh?) whatever you type into this box will be completely ignored!

A little red text, or a warning icon with hover info explaining why you can’t set or change the workflow concurrency for this particular workflow feels like a must.

Note: that in a perfect world, the app might know if workers with fast-lanes are currently connected and only disable the setting if fast-lanes are turned on. It also might communicate the uncertainty, and say "sure, change this setting all you want, but in the future if someone turns on or off fast-lanes, whether or not this setting is respected will change"

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the UI workflow concurrency input and trace how it detects a workflow's sync-mode webhook trigger. Make the setting visibly disabled or warn users that the value may be ignored when sync mode is enabled, then verify the resulting behavior and message for affected workflows.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.