No error returned when connecting to run channel with invalid key
Nobody has claimed this yet.
- Dominant language
- Elixir
- Stars
- 296
- Forks
- 86
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 50
Description
When the worker is trying to join
See sister issue kit#1102https://github.com/OpenFn/kit/issues/1102
Repro Steps
- Clone
main - Go through the usual setup to get started
- unset
WORKER_RUNS_PRIVATE_KEY - Start the app - no alarms
- Try and manually trigger a run
Nothing will happen. The run will be pending forever and get lost. There will be no error or warning in the sever logs (if there is, I haven't seen it yet!)
Expected Behaviour
Well this is an open question.
First of all Lightning needs to return a clear error to the channel in this case. I don't quite know what that looks like.
Should lightning do anything else when a worker fail to connect? Should it send an email or log anything in particular?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the worker's run-channel connection flow and reproduce the issue using the listed setup, including unsetting WORKER_RUNS_PRIVATE_KEY and manually triggering a run. Done should include a clear channel error and an agreed response for failed worker connections, but the expected behavior remains an open question.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elixir
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100