OpenFn / OpenFn/lightning

sandboxes: changing colours in Edit mode is a bit wierd

Open
#3,588 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

sandboxes and sync
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

In the Sandbox UI, the user can click to Edit a sandbox, and change the colour.

As the colour is switched, the whole app changes in realtime to show users the consequence of the change. This is really cool, and really important feedback to the user!

But there are two major problems with it, which we'll need to resolve one day:

  • The background modal is grey, so the user isn't seeing real colour, which makes it a bit harder to see the impact of your choice
  • When you hit "Save", unless you happen to be editing the current sandbox, the colour will revert back - because of course you're editing a sandbox you're not looking at. This is correct, but weird! I think a nice solution would be to have three buttons: Cancel, Save, and Save & Switch (which saves your changes and switches into that sandbox). I don't think Save & Switch is desirable functionality, but I DO think that the presence of the button makes the behaviour much more predictable.

Raised out of #3588

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the Sandbox UI edit flow and reproduce changing a sandbox colour, including saving while viewing a different sandbox. Trace the modal and save behavior first. Done means colour previews are understandable in the modal and the save outcome is predictable, including the proposed Save & Switch option.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.