OpenFn / OpenFn/lightning

Internal Server Error: Viewing a workflow with non-existing version number crashes the application

Open
#3,375 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

Describe the bug
Open a workflow and try to view a snapshot version by appending ?v=<number> in the URL. non-existing version numbers will make the application crash. Shouldn't we be robust enough? Shouldn't non-existing version numbers be ignored and considered as latest?

Version number v2.13.4 (1.5.16)

If you're running on a tagged version, include the number: vX.Y.Z

If you're running locally with an unreleased version, the commit sha: 84b1bdc

I have reproduced this locally on main:

  • Yes
  • No

To Reproduce Steps to reproduce the behavior:

  1. Go to any workflow
  2. Update the url in the browser with a version number eg. ?v=99
  3. Internal Sever Error.

Expected behavior
It's supposed to ignore the non-existing version number and then show us the latest version

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by opening a workflow and appending ?v=99 to the URL, as described in the report. Trace the request handling for workflow snapshot versions and verify that a non-existing version no longer causes an Internal Server Error and instead displays the latest version.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.