OpenFn / OpenFn/lightning

Consider better approach for inline-block button links

Open
#3,269 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

We should consider another approach on the inline-block style on the button_link component.

It's not impacting anything now, since none of those button_links rely on hidden or JS.show() and JS.hide() to display properly, but if we DID introduce a button_link that's hidden by default in the future we'd run into a common Tailwind gotcha: https://claude.ai/share/f023167c-99f9-48e2-96fc-0a43aa8822cb

Related to https://github.com/OpenFn/lightning/issues/3265

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the button_link component and reviewing its inline-block styling alongside Tailwind's hidden behavior and JS.show()/JS.hide(). Read related issue #3265 and determine a concrete approach for links that may be hidden by default; done means the component's display behavior remains correct in that case.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir, tailwindcss
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.