OpenFn / OpenFn/lightning

Write end to end tests for the manual run component

Open
#3,219 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

Details

There are tests that have been skipped awaiting to be added when we have frontend testing configured.

The tests lie on these 2 files:

  • test/lightning_web/live/workflow_live/editor_test.exs
  • test/lightning_web/live/workflow_live/edit_test.exs

These tests have been tagged with skip: "component moved to react", a simple grep will show all of them.

Key things to consider while writing these new tests:

  • **Authorization: ** how should the component behave when users with different roles access it?
  • **Snapshots: ** when viewing a snapshot in the editor, the user shouldn't be able to edit

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by grepping for skip: "component moved to react" in test/lightning_web/live/workflow_live/editor_test.exs and test/lightning_web/live/workflow_live/edit_test.exs, then read the skipped cases and the manual run component. Add end-to-end coverage for behavior across user roles and ensure snapshot views cannot be edited. Done means the skipped tests are replaced with passing frontend tests covering authorization and snapshot editing restrictions.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir, react
Domain
frontend, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.