OpenFn / OpenFn/lightning

Common banner text is centralized and doesn't show icon

Open
#2,464 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

<Common.banner
          type="danger"
          id="canvas-banner-limit"
          message={@limit_banner_message}
          class="absolute"
          icon={true}
          centered={true}
/> 

Version number

2.8.2

I have reproduced this locally on main:

  • Yes
  • No

To Reproduce Steps to reproduce the behavior:

  1. On the Billing App, on branch ai-assistant-limiter uncomment this banner on the workflow_live/edit.ex
  2. Set @default_ai_limit to small value in subscriptions_usage.ex
  3. Send some AI questions/queries until the limit.
  4. See error that the banner text is not centralized and doesn't show the icon.

Expected behavior A clear and concise description of what you expected to
happen.

icon and centered boolean attributes are considered.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Common.banner usage in workflow_live/edit.ex and the limit setup in subscriptions_usage.ex, following the reproduction steps on the ai-assistant-limiter branch. Inspect how the banner handles the icon and centered attributes, then verify that the reproduced limit banner displays its text, icon, and centered layout as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.