OpenFn / OpenFn/lightning

Workflow Diagram: allow new paths to be created from trigger nodes

Open
#2,357 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

In the workflow diagram, users cannot create new paths on a trigger, nor can they remove paths.

This is by design, but it becomes very problematic if users want to move the trigger-path from one node to another. It's also a bit of a shame that you can't create multiple branches from a trigger, because why not really?

This probably needs a bit of thinking through. I think when we originally added this constraint, the diagram didn't handle orphaned nodes. And also new edges couldn't be created. So back then, it put the chart in a broken state to remove the trigger edge.

But I think now we could safely allow this.

From the Runtime's perspective, a trigger is just a starting node without a body. We can support any number of edges from a trigger node, no problem.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Locate the workflow diagram's trigger-node and edge-creation/removal entry points, then trace the existing restriction and orphan-node handling. Done means trigger nodes can create multiple paths and remove or move existing paths without leaving the diagram in a broken state.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.