OpenFn / OpenFn/lightning

Find a way to test Phoenix Presence

Open
#2,311 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

We're skipping these 4 tests since they're super flaky—they slow down the development process too much to keep. This issue is to add them back and find a way to test Phoenix Presence. (Remains to be seen how critical this is, and whether or not this will be superseded by an all-React canvas/inspector experience.)

Skipped tests from LightningWeb.WorkflowLive.UserPresencesTest to restore and fix for flakiness:

  • "When workflow has many visitors, presences is detected and edit is disabled" (in canvas and inspector)
  • "When workflow has many visits from same user, multiple sessions are detected and edit is disabled" (in canvas and inspector)

https://github.com/OpenFn/lightning/blob/main/test/lightning_web/live/workflow_live/user_presences_test.exs

For testing, run with mix test test/lightning_web/live/workflow_live/user_presences_test.exs and with mix test to check for flakes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/lightning_web/live/workflow_live/user_presences_test.exs and run mix test test/lightning_web/live/workflow_live/user_presences_test.exs to inspect the skipped presence tests and their flakiness. Restore and stabilize the listed canvas and inspector scenarios, then run mix test to confirm the suite remains reliable.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.