OpenFn / OpenFn/lightning

Render 404 page when no workflow snapshot is found

Open
#2,272 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug DevX
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

When visiting the workflow edit page, one can pass a URL parameter to control the loaded snapshot version. That parameter is v, and it expects a positive integer value. That value is then queried in the database to find the associated workflow snapshot. When no snapshot is found, the app crashes. Instead of the app crashing we should return a 404 page.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the workflow edit page entry point and follow how the v URL parameter is used to query the workflow snapshot. Check the missing-snapshot path and verify that it renders a 404 page instead of crashing. Confirm the behavior for both an existing and a nonexistent snapshot version.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.