OpenFn / OpenFn/lightning

Credential form not picking up default values when creating a new credential

Open
#2,255 0 comments 0 reactions 1 assignee View on GitHub

@elias-ba is already working on this.

Since Jul 4, 2024.

bug
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

Description
When creating a new credential, the form does not populate the default values that are specified in adaptor configuration-schema. If the user creates a new credential without editing the fields that have default values this can cause problem during workflow execution.

For example.
I was trying to connect mssql database that requires the encrypt to be set to true. Since i new that by default mssql adaptor set the encrypt value to true i created the mssql credential without checking the Encrypt box. This cause the job to fail with the following error Server requires encryption, set 'encrypt' config option to true.

Steps to Reproduce:

  1. Navigate to the credential creation page.
  2. Click on the "Add new Credential" button.
  3. Select mssql adaptor
  4. Observe the form fields that should have default values. See mssql configuration schema here

Expected Behavior:
The form fields should automatically populate with the predefined default values.

Actual Behavior:
The form fields port, Encrypt, RowCollectionOnRequestCompletion and TrustServerCertificate remain empty, requiring manual input for each field.

Screenshots:
Screenshot 2024-07-04 at 3 51 36 PM

Environment:
I have reproduced this locally on main v2.7.2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.