OpenFn / OpenFn/lightning

Race condition when triggering github sync from openfn while deploy actions are running

Open
#2,179 5 comments 0 reactions 1 assignee View on GitHub

@midigofrank is already working on this.

Since Jun 6, 2024.

bug
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

Will add more details later..

@mtuchi ran into a situation where one of his deploy workflows could not complete because his branch was out of date with the remote branch. Know that git error which tells you to pull from the remote first?

He said he did a push to his branch and then triggered a sync from openfn. My gut tells me that the sync from lightning did a commit before one of his workflows could complete. I think this is possible given that the deploy workflows are currently running sequentially, while the pull ones aren't.

Maybe we should have the pull actions running in the openfn-deployment group as well so that we avoid all these race conditions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.