OpenFn / OpenFn/lightning

Solve the `other_params` problem (UberAuth/OAuth2 library)

Open
#1,693 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

UberAuth/OAuth2 puts stuff from the token inside other_params and we don't like that! We want to save the body as it comes from the provider, because that's how CLI users, developers, and our adaptors will expect it... the token body from the provider should go right into state.configuration.

This issue is to clean up the current gymnastics around flattening and unflattening into other_params

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the UberAuth/OAuth2 token handling and the path into state.configuration, starting with the current flattening and unflattening around other_params. Done means the provider's token body is preserved directly in state.configuration and the other_params gymnastics are removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
authentication
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.