OpenFn / OpenFn/lightning

Harmonize different uses of new inputs

Open
#1,590 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature enhancement
Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

The inputs from the LightningWeb.Components.NewInputs have some behaviours that generated discussion while implementing the JS expression, namely in regards to:

  1. Font weight of the label when the input's label attribute is set
    (Figma required one but the input provided another and customization was avoided for a more general solution)
  2. The distance reserved for the error and its appearance which for the Edge/Path was solved with a specific solution to this form.
  3. When the error of required fields should be shown (for the Edge/Path form there was also specific solution requested to show only if a previous input/field was skipped).
  4. The red highlighting on the border of the input for the last input edited when it has invalid data.

Version
v0.12.0

As mentioned above the space and display of the error on Edge form was fixed on #1573 for this form so v0.12.1 shows the error correctly.

I have reproduced this locally on main:

  • Yes
  • No

To Reproduce Steps to reproduce the behavior:

  1. For the edge form, select an edge on a workflow and choose the condition type to Match a JS expression
  2. For the highlighting, access the forms to create a raw credential and to create a webhook secure authorization.

image
Screenshot from 2023-12-23 17-35-21
Screenshot from 2023-12-23 17-33-56
Screenshot from 2023-12-23 17-53-42

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the LightningWeb.Components.NewInputs components and compare their behavior in the edge form, raw credential form, and webhook secure authorization form. Read the error-handling solution in PR #1573 and review the linked screenshots and issue discussion. Done means the label weight, error spacing and visibility, and invalid-input highlighting are consistent across these forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.