OpenFn / OpenFn/lightning

Relax log event restrictions for runs

Open
#1,544 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Elixir
Stars
296
Forks
86
Avg merge
1d 13h
Merged PRs (30d)
50

Description

If a worker has a valid token, they should be able to send data to lightning about a run regardless of whether or not an run:complete event has already been received.

Why?

Because we shouldn't rely on the receipt order of web traffic to build up our final understanding/picture of a run. Individual log lines might (on occasion) come out of order, events might arrive in the wrong order, stuff might even be processed out of order on the lightning side if lightning-web is in the middle of a rolling restart.

We should limit fetch:credential and fetch:dataclip requests to "only once ever" and, in the meantime, we might consider not allowing them to happen after run:complete but generally, I think our Lightning restrictions here should be based on something other than the order in which we process the websocket events.

@stuartc , what's your thinking here?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the websocket handling for run:complete, fetch:credential, and fetch:dataclip events. Confirm where valid-token checks and post-completion restrictions are applied, then verify that ordinary run data is accepted regardless of event order while credential and dataclip requests remain limited to one occurrence.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.