Port `crash_test` to `janitor_test`
Open
Nobody has claimed this yet.
question
- Dominant language
- Elixir
- Stars
- 296
- Forks
- 86
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 50
Description
- A bunch of interesting crash-handling logic was tested in
crash_test. - While some is no longer necessary, basic
Janitorfunctionality should be tested. - This issue is complete when a PR shows how each test from
crash_testhas been ported to a newjanitor_testmodule, is tested elsewhere in the app, or is truly no longer needed.
Notes:
- Crash Test:
test/lightning/crash_test.exs - Existing Janitor testing in query_test: https://github.com/OpenFn/Lightning/blob/release-0.10.0/test/lightning/attempts/query_test.exs#L8
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare test/lightning/crash_test.exs with the existing Janitor testing referenced in test/lightning/attempts/query_test.exs. Review each crash-handling test and determine whether it belongs in a new janitor_test module, is already tested elsewhere, or is no longer needed. Done means a PR accounts for every test and adds the necessary Janitor coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elixir
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100