OpenFn / OpenFn/kit

worker: on socket error, report workflow complete (with crash exit)

Open
#920 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

DevX
Dominant language
TypeScript
Stars
21
Forks
23
Avg merge
1d 22h
Merged PRs (30d)
17

Description

When there's an error on a critical workflow event, the run will be a lost - which gives us all sorts of problems

Maybe what we need to do is stop the workflow at this point (? Can we even stop the runtime?) and send a complete-with-crash state to lightning

See https://github.com/OpenFn/kit/blob/e11e55169cfa6186426e2aa84a23ecaffaa2d7e8/packages/ws-worker/src/server.ts#L319

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at packages/ws-worker/src/server.ts around line 319 and trace how critical workflow events handle socket errors. Determine how the runtime is stopped at that point and how the complete-with-crash state is sent to Lightning. Done means a socket error reports the workflow as complete with a crash instead of leaving the run lost.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.