OpenFn / OpenFn/kit

Runtime: warn when a trigger edge is disabled or fails

Open
#904 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

DevX
Dominant language
TypeScript
Stars
21
Forks
23
Avg merge
1d 22h
Merged PRs (30d)
17

Description

Idea: we had a problem recently where a project imported for v1 had its first edge (the trigger-job edge) was disabled. This meant that run had no steps and looked super weird in Lightning.

We should be able to:

  1. warn when the trigger step edge is disabled (because this should never happen)
  2. warn when the trigger edge condition returns false

In both cases the run will look pretty strange in Lightning. I think we should be able to add logging to make it a bit clearer.

Difficulty: if there's no step, is Lightning able to show the logs?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the runtime code that handles the first trigger-job edge, and inspect how disabled edges and false edge conditions are currently processed. Check existing logging and how Lightning displays runs with no steps; done means both cases produce clear warnings that can be observed for the affected run.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.