OpenFn / OpenFn/kit

Lazy state: doesn't work in non-operation function arguments

Open
#745 7 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
21
Forks
23
Avg merge
1d 22h
Merged PRs (30d)
17

Description

This:

fnIf(
  Object.values($.results).length === 0
  state => console.log(`Couldn't find records for '*:${state.cursor}*'`)
}

Compiles to this:

fnIf(Object.values(state => state.results).length === 0, state =>
  console.log(`Couldn't find records for '*:${state.cursor}*'`)
)];

Which is wrong. We needed to walk a bit higher up the try to work out where to put the wrapping function.

Should be:

fnIf(
  state => Object.values(state.results).length === 0
  state => console.log(`Couldn't find records for '*:${state.cursor}*'`)
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.