OpenFn / OpenFn/kit

worker isn't running NODE_ENV=production ?

Open
#651 2 comments 0 reactions 1 assignee View on GitHub

@josephjclark is already working on this.

Since Jan 11, 2025.

bug DevX
Dominant language
TypeScript
Stars
21
Forks
23
Avg merge
1d 22h
Merged PRs (30d)
17

Description

The worker environment isn't running with NODE_ENV set to production.

This isn't neccessarily a problem, but it does mean that Lightning is printing deprecation notices on the old common.http helpers. It shouldn't really be doing that - the deprecation notice is designed only to come out in the CLI because the message is targeted at adaptor writers. Job writers can't do anything about it.

Probably the main worker server is running in prod mode, but the nested child process worker environment isn't inheriting it.

Maybe its even the sandbox - the sandbox, very deliberately, doesn't inherit the parent env. But maybe we should pipe NODE_ENV through.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.