OpenFn / OpenFn/kit

New deploy: breaks when step id changes

Open
#1,173 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

DevX
Dominant language
TypeScript
Stars
21
Forks
23
Avg merge
1d 22h
Merged PRs (30d)
17

Description

If you change a step id in workflow.yaml, you'll get errors on deploy.

This comes from problems in from-fs, I think because it fails to reconcile the new step in the local workflow against the stuff in the project.yaml file.

I think like #1171 , this comes back to doing a merge when loading from the file system. That should reconcile all changes - and if it doesn't, that just means a new fix in merge and load

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the from-fs loading and merge logic for workflow.yaml and project.yaml, then review issue #1171 for related context. Reproduce a deploy after changing a step id and trace whether the local workflow is reconciled with the project configuration; done means the deploy succeeds with the renamed step.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.