OpenFn / OpenFn/apollo

Stop emitting names Lightning rejects

Open
#655 0 comments 0 reactions 1 assignee View on GitHub

@elias-ba is already working on this.

Since Sep 1, 2026.

Dominant language
Jupyter Notebook
Stars
5
Forks
10
Avg merge
2d 20h
Merged PRs (30d)
17

Description

sanitize_name("‍", unicode_mode=True) returns a name made entirely of a zero-width joiner, which Lightning refuses. And a hundred ZWJ families is 100 graphemes but 700 codepoints, against Lightning's 255-codepoint column, so we would emit a name Lightning rejects. The grapheme cap bounds neither.

This is what gates APOLLO_UNICODE_STEP_NAMES.

Two smaller things while we are in here. The parametrizations at test_name_rules.py:353-362 do del expected and then assert a property derived from the function under test, so they survive replacing _fallback_clusters with lambda t: list(t). And the root conftest.py network guard blocks socket.socket.connect but not create_connection or getaddrinfo.

The other items this issue used to carry are resolved in #658.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.