echo: stop reflecting the full payload
Open
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 5
- Forks
- 10
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 17
Description
While reviewing the timeout work I noticed echo returns its input verbatim and logs it. Payloads that reach a service can carry values the server set rather than the caller, so reflecting one wholesale is not a good default.
#635 covers this:
echoruns its payload through themask_secretshelper that already existed for Langfuse traces, and that helper now covers every field the server may fill in rather than only the one it fills in today- masking moved to the boundary rather than sitting in one service, so a service that reflects its payload cannot leak by forgetting: service loggers mask what they emit, and every result leaves through one masked exit
- a test drives that exit through an unmounted probe that reflects its payload and masks nothing itself, so it fails if the boundary stops working rather than merely proving
echobehaves
Closing when that merges.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the related work in #635 and the existing mask_secrets helper used for Langfuse traces. Inspect the service loggers, the single result exit, and the unmounted probe test described in the issue. Done means reflected payloads and emitted logs are masked at the boundary, including fields the server may fill in.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 20/100