OpenFn / OpenFn/apollo

logging request times doesn't work well for streams

Open
#459 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

monitoring
Dominant language
Jupyter Notebook
Stars
5
Forks
10
Avg merge
2d 20h
Merged PRs (30d)
17

Description

When taking a streaming request through apollo, we record the HTTP get instantly, after a few ms, even though the streaming connection might take up to a minute.

We should do something else in this case. Maybe teh streaming services can log time to complete. Or maybe we can modify the HTTP layer to says stream start / stream end

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the HTTP layer and streaming services to see where request timing is currently recorded. Compare logging stream start and stream end with logging completion time in the streaming service, and define done as accurate timing for streaming connections; no specific files or tests are named.

Written by the indexing model from the issue text.

Assessment

Domain
backend, observability
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.