OpenFn / OpenFn/adaptors

`mssql` error handling

Open
#732 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

DevX
Dominant language
JavaScript
Stars
24
Forks
41
Avg merge
3d 13h
Merged PRs (30d)
12

Description

Description

Different Error logs btn CLI and worker
When running the same job on lightning with the following version 👇

VER Versions:
    ▸ node.js                      18.20.4
    ▸ worker                       1.5.0
    ▸ @openfn/language-mssql       5.0.1

I am getting an error saying

ADA Uncaught exception in worker thread (workflow c0b0fe05-cb43-4d4a-8b51-8fd60afa48d0 )
ADA {
  "message": "AggregateError",
  "name": "AggregateError"
}

Screenshot 2024-08-21 at 9 07 38 AM

But when running it locally with CLI

 ♦ Versions:
    ▸ node.js     18.12.1
    ▸ cli         1.8.1

I get more error logs that make it easy to troubleshoot

Screenshot 2024-08-21 at 9 12 30 AM

Request In few words
Update mssql adaptor to pre-format error message then throw them

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the mssql adaptor and reproduce the same job through the CLI and worker using the versions described in the report. Compare their error output and verify that the adaptor’s reported errors remain detailed enough to troubleshoot in both environments.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js, sql
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.