OpenFn / OpenFn/adaptors

Remove `superagent`

Open
#548 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
24
Forks
41
Avg merge
3d 13h
Merged PRs (30d)
12

Description

We should migrate all adaptors away from superagent

Some old versions of superagent have vulnerabilities (through qs), although I believe these are all dependencies. So it's not really dangerous, just untidy.

Affected packages should either:

  1. migrate to the new common http utils (preferable)
  2. migrate to use undici as a direct replacement

The affected adaptors appear to be:

@openfn/language-beyonic@0.2.1 
@openfn/language-cartodb@0.2.1 
@openfn/language-commcare@1.6.12  (done!)
@openfn/language-magpi@1.1.2 
@openfn/language-mailchimp@0.7.3 
@openfn/language-openhim@0.2.1 
@openfn/language-telerivet@0.2.1 
@openfn/language-zoho@0.3.1 

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the listed adaptor packages and locating their remaining superagent usage; the CommCare adaptor is already marked done. Compare each package with the new common HTTP utilities first, using undici only as the stated alternative. Done means all affected adaptors no longer depend on superagent and their existing adaptor tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.