OpenFn / OpenFn/adaptors

Remove `request`

Open
#547 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
24
Forks
41
Avg merge
3d 13h
Merged PRs (30d)
12

Description

The request package has been deprecated and must be removed.

Affected packages should either:

  1. migrate to the new common http utils (preferable)
  2. migrate to use undici as a direct replacement

(2) should be straighforward because at least undici has a WHATWG compatible fetch function, which I presume is a straight swap. Testing, as ever, is the hardbit.

The affected packages appear to be:

@openfn/language-bigquery@2.0.6 (through an old version of our `http`)
@openfn/language-dynamics@0.4.10
@openfn/language-facebook@0.3.2
@openfn/language-khanacademy@0.4.1
@openfn/language-magpi@1.1.2
@openfn/language-maximo@0.4.1
@openfn/language-medicmobile@0.4.2
@openfn/language-mogli@0.4.1 (through jsforce)
@openfn/language-nexmo@0.4.5
@openfn/language-primero@2.11.10 (through `nexmo`)
@openfn/language-resourcemap@0.3.2
@openfn/language-salesforce@4.6.2 (through `jsforce`)
@openfn/language-smpp@1.3.1
@openfn/language-vtiger@1.2.1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the listed affected adaptor packages and their dependency trees to locate direct or transitive uses of request, starting with the packages named in the issue. Migrate to the common HTTP utilities where possible or to undici, then verify that request is removed and the affected package tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.