OpenFn / OpenFn/adaptors

common: getLastReference always returns first reference

Open
#274 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
24
Forks
41
Avg merge
3d 13h
Merged PRs (30d)
12

Description

The common adaptor has a function called lastReferenceValue:

export function lastReferenceValue(path) {
  const lastReferencePath = referencePath('[0]'.concat('.', path));

  return sourceValue(lastReferencePath);
}

Note that it always returns from references[0];

composeNextState will append old data to the end of the references array:

export function composeNextState(state, response) {
  return {
    ...state,
    data: response,
    references: [...state.references, state.data],
  };
}

Ie, the most recent data is at the end of the array.

So getLastReference() will always return the first reference.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the common adaptor's lastReferenceValue and composeNextState functions. Trace how references are appended and verify that getLastReference() returns the most recent reference rather than the first; done means the behavior is corrected and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.