OpenFeign / OpenFeign/feign

Retry based on status code list given as parameter

Open
#870 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feign-12 proposal waiting for votes
Dominant language
Java
Stars
9.8k
Forks
1.9k
Avg merge
1d 2h
Merged PRs (30d)
41

Description

As written in #731 , the current logic treats all IOExceptions from a Client as something that is network related and that's why it try to do retry but not all of the IOExceptions are related to connectivity.
There are IOExceptions that I don't want to retry after I got them. (for example, when trying to serialize/deserialize or dealing with files).

In Addition, maybe we can add a optional parameter to do a retry based on list of status codes we get as parameter.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the retry behavior described in issue #731 and trace the Feign Client logic that currently retries IOExceptions. Clarify how connectivity-related exceptions and a caller-provided status-code list should interact; done means the issue's non-retryable IOExceptions are excluded and configured status codes control retries, with tests covering both paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.