OpenFeign / OpenFeign/feign

Support Conditional Parameter Expansion

Open
#521 19 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feign-12 proposal waiting for votes
Dominant language
Java
Stars
9.8k
Forks
1.9k
Avg merge
1d 2h
Merged PRs (30d)
41

Description

Hi!

We define our Spring MVC APIs with @RequestParam Optional<Type> something.

It looks like Feign doesn't handle it well and uses "toString()" version so that Spring fails to convert String -> Optional

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Feign's request-parameter expansion and how Optional values are converted when calling a Spring MVC API. Reproduce the issue with @RequestParam Optional; done means conditional expansion produces a value Spring can convert instead of the Optional object's toString() form.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.