OpenFeign / OpenFeign/feign

When using FeignClient, an error occurs when a value with a special structure is passed in the header map

Open
#2,739 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
9.8k
Forks
1.9k
Avg merge
1d 2h
Merged PRs (30d)
41

Description

feign-core:11.8
When the content of my header map is as follows, the following exception is throw
headerMap:
{
"x-test":{"test":["123:861"]}
}
error:
java.util.regex.PatternSyntaxException: Unclosed character class near index 4
["123
^
at java.base/java.util.regex.Pattern.error(Pattern.java:2204)
at java.base/java.util.regex.Pattern.clazz(Pattern.java:2869)
at java.base/java.util.regex.Pattern.sequence(Pattern.java:2315)
at java.base/java.util.regex.Pattern.expr(Pattern.java:2245)
at java.base/java.util.regex.Pattern.compile(Pattern.java:1945)
at java.base/java.util.regex.Pattern.(Pattern.java:1576)
at java.base/java.util.regex.Pattern.compile(Pattern.java:1101)
at feign.template.Expression.lambda$new$0(Expression.java:35)
at java.base/java.util.Optional.ifPresent(Optional.java:178)
at feign.template.Expression.(Expression.java:35)
at feign.template.Expressions$SimpleExpression.(Expressions.java:106)
at feign.template.Expressions.create(Expressions.java:86)
at feign.template.Template.parseFragment(Template.java:218)
at feign.template.Template.parseTemplate(Template.java:202)
at feign.template.Template.(Template.java:61)
at feign.template.HeaderTemplate.(HeaderTemplate.java:82)
at feign.template.HeaderTemplate.create(HeaderTemplate.java:48)
at feign.RequestTemplate.lambda$appendHeader$3(RequestTemplate.java:748)
at java.base/java.util.TreeMap.callRemappingFunctionWithCheck(TreeMap.java:792)
at java.base/java.util.TreeMap.compute(TreeMap.java:722)
at feign.RequestTemplate.appendHeader(RequestTemplate.java:746)
at feign.RequestTemplate.header(RequestTemplate.java:708)
at feign.ReflectiveFeign$BuildTemplateByResolvingArgs.addHeaderMapHeaders(ReflectiveFeign.java:294)
at feign.ReflectiveFeign$BuildTemplateByResolvingArgs.create(ReflectiveFeign.java:243)
at feign.SynchronousMethodHandler.invoke(SynchronousMethodHandler.java:84)
at feign.ReflectiveFeign$FeignInvocationHandler.invoke(ReflectiveFeign.java:100)
at jdk.proxy2/jdk.proxy2.$Proxy144.getOrderDetail(Unknown Source)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the feign-core 11.8 stack trace, reading ReflectiveFeign.java and RequestTemplate.java around header-map handling, then follow HeaderTemplate.java, Template.java, Expressions.java, and Expression.java. Reproduce the failure with the shown nested header value; done means the request no longer throws PatternSyntaxException for that input and the behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.