Allow for 3xx range headers
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.8k
- Forks
- 1.9k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 41
Description
Everything above 299 is considered an error, which is plainly incorrect.
To get around this I had to:
- add an error decoder
- throw a special exception for 3xx range
- when catching runtime errors, check if it is the special 300 error
- convert to a valid response entity
Will investigate replacing this line:
if (response.status() >= 200 && response.status() < 300) {
in SynchronousMethodHandler and PR'ing it. I just wonder why nobody else has come across this issue.
Should I fix it?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in SynchronousMethodHandler at the response-status condition quoted in the issue and inspect how 3xx responses are decoded and converted to response entities. Add or update coverage for 3xx responses with headers, and consider the issue done when those responses no longer enter the error path while other status handling remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100