OpenFeign / OpenFeign/feign

What was the need to do it in such a way?

Open
#2,412 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feedback provided
Dominant language
Java
Stars
9.8k
Forks
1.9k
Avg merge
1d 2h
Merged PRs (30d)
41

Description

https://github.com/OpenFeign/feign/blob/aded5d5ac7f0cd7c57722c9aa9e5c9539783a897/core/src/main/java/feign/BaseBuilder.java#L252

In previous version of this file we were not cloning it. We were directly changing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with core/src/main/java/feign/BaseBuilder.java around line 252 and compare it with the previous version referenced in the issue. Trace the cloning and mutation behavior, then establish and document the intended rationale or agree on a follow-up change; the issue is done when that decision is recorded.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.