UriUtils.encode should not skip already encoded strings
@kdavisk6 is already working on this.
Since Sep 16, 2024.
- Dominant language
- Java
- Stars
- 9.8k
- Forks
- 1.9k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 41
Description
I ended up here using feign because of a seemingly simple task: encode a String using RFC 3986.
Against the odds, this turns out to be quite complicated. Java fails because the URLEncoder is not for URIs, due to the Space=+...
Apache does not work, Guava does not have a decoder...
Now feign... I couldn't believe my eyes when my property based tests failed to properly encode the literal String "%07"...
I look into the code and find stuff like "skips already encoded strings"... :(
This is a very bad design decision in itself, but even worse: how does one now encode such a literal string? I cannot find an option to disable this (for me) unwanted behaviour...
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.