OpenFeign / OpenFeign/feign

ApacheHttpClient - enable/disable follow redirect via Request.Options

Open
#1,859 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
9.8k
Forks
1.9k
Avg merge
1d 2h
Merged PRs (30d)
41

Description

Hi there.

With spring-cloud-openfeign, it is possible to specify feign configuration by client with :

feign:
    client:
        config:
            feignName:
                connectTimeout: 1000
                follow-redirects: false

But when using the ApacheHttpClient, the property follow-redirects is ignored (whereas connectTimeout is ok)

I think it could be achieve by adding :

.setRedirectsEnabled(options.isFollowRedirects())

line 95 of ApacheHttpClient

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read ApacheHttpClient around line 95 and trace how Request.Options reaches the request configuration. Confirm that follow-redirects=false is honored when using ApacheHttpClient, while preserving the existing connectTimeout behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.