OpenFeign / OpenFeign/feign

Why not support multiple @QueryMap at the same time

Open
#1,504 4 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
9.8k
Forks
1.9k
Avg merge
1d 2h
Merged PRs (30d)
41

Description

I have an API that looks something like this :

    @GetMapping("demo")
    public String demo(PageParam pageParam, Query query){
        return "success";
    }

I wish I could call this in feign Client:

public interface DemoFeignClient {
    @GetMapping("demo")
    String demo(@QueryMap PageParam pageParam,  @QueryMap Query query);
}

But feign only passes the attributes of the first object.

Why not support simultaneous use @QueryMap ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how Feign processes the @QueryMap annotations shown in the issue and how it builds the request query parameters. Determine whether both PageParam and Query can contribute fields, then verify that a request using two @QueryMap parameters includes attributes from both objects.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.