OpenEnergyPlatform / OpenEnergyPlatform/oeplatform

Logic of interaction during OPR

Open
#2,355 0 comments 0 reactions 1 assignee View on GitHub

@vismayajochem is already working on this.

Since Jun 25, 2026.

open peer review
Dominant language
Python
Stars
65
Forks
29
Avg merge
15h 25m
Merged PRs (30d)
32

Description

Description of the issue

Currently, the logic of what happens when fields are not just accepted is not always clear. For example what happens to the value of a field when a suggestion after a suggestion is denied.

Ideas of solution

In most cases the process and outlet are clear. However, here some ideas for unclear cases:

  1. Denying a field always brings the value, which needs to be reviewed by the next party, to the value discussed immediately before. Meaning, when a field is denied by the reviewer on the first review, the value the contributor can decide on is null. When there is a suggestion which gets denied, the value becomes the original value. If a suggestion after another suggestion gets denied, the value becomes the value of the first suggestion, and so on.
  2. The contributor always has all three options: Accept, suggest, and deny.
  3. If a value was denied by one side and the other side denies that denial there is obviously a direct conflict and therefore the value gets set to null, meaning the field gets deleted from the review. Technnical fields and the license fields are excepted from that rule. When in one of these fields a double deny (two denies directly after each other) occurs, the whole OPR process is terminated.

Workflow checklist

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.