OpenDroneMap / OpenDroneMap/ODM
Missing comma in shutter regex list
Open
- Dominant language
- Python
- Stars
- 6.5k
- Forks
- 1.3k
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 4
Description
Via this post,
File: opendm/video/srtparser.py
Due to a missing comma, two regex patterns are unintentionally concatenated into a single string:
shutter = match_single([
"shutter : \d+/(\d+\.?\d*)"
"SS (\d+\.?\d*)"
], line)
Suggested fix:
shutter = match_single([
"shutter : \d+/(\d+\.?\d*)",
"SS (\d+\.?\d*)"
], line)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open pull request #1994 is already linked to this issue. Review opendm/video/srtparser.py and the proposed change there; done when the shutter regex list keeps its two patterns separate and the affected SRT parsing behavior is covered or verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 15/100