Possible Bug: pc-geometric breaking reconstruction on non-georeferenced data

Open
#1,687 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python

Research direction

No source files, tests, dataset, or task log are identified in the issue. Start by reproducing reconstruction with non-georeferenced data and the default --pc-geometric setting, then trace the reconstruction stage that emits “Type 1 / Strange Values”; done means the failure is fixed or the option is disabled there with a log warning.

Written by the indexing model from the issue text.

Description

enhancement
How did you install ODM? (Docker, installer, natively, ...)?

Any

What is the problem?

Users are reporting that reconstruction can fail with Type 1 / Strange Values when --pc-geometric (default on, now) is used against datasets without georeference information.

https://community.opendronemap.org/t/better-results-on-surfaces-with-pre-odm-3-0-0/15547/12?u=saijin_naib

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

If --pc-geometric can be used without georeference, it needs to be fixed. If it can not, it needs to be disabled during the appropriate stage with a log warning.

How can we reproduce this? What steps did you do to trigger the problem? If this is an issue with processing a dataset, YOU MUST include a copy of your dataset AND task output log, uploaded on Google Drive or Dropbox (otherwise we cannot reproduce this).

Pending

Dominant language
Python
Stars
6.5k
Forks
1.3k
Avg merge
5d 6h
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenDroneMap/ODM

All issues in OpenDroneMap/ODM

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.