OpenDroneMap / OpenDroneMap/ODM
`benchmark.txt` updated when step is passed
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6.5k
- Forks
- 1.3k
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 4
Description
How did you install ODM? (Docker, installer, natively, ...)?
Docker
What is the problem?
The file benchmark.txt is updated even if the step was not actually computed but simply passed because the corresponding files were found.
As a consequence, if a project is treated in multiple executions (for example, it stoped for any reason in the middle and is resumed from there), the time of the steps of the first execution(s) won't be representative.
What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.
I would expect benchmark.txt not to be updated for a given step if the corresponding output was found instead of computed.
How can we reproduce this? What steps did you do to trigger the problem? If this is an issue with processing a dataset, YOU MUST include a copy of your dataset AND task output log, uploaded on Google Drive or Dropbox (otherwise we cannot reproduce this).
- Launch a reconstruction project
- Ctrl+C after some steps to mimic an unwanted crash
- Resume the reconstruction project
- Look at
benchmark.txt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing where benchmark.txt is written during a reconstruction project and how resumed steps are identified as already completed. Reproduce the interrupted-and-resumed workflow, then verify that benchmark.txt records only steps that were actually computed, not steps whose outputs were reused.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 43/100