OpenDevicePartnership / OpenDevicePartnership/patina
Tracking Issue: Add patina_test tests back when UEFI Service mocking is available
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 544
- Forks
- 54
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 30
Description
Three tests are ignored in patina/components/patina_test/src/component.rs today:
At this time, these are the only unit tests in library code that are ignored and do not run successfully (panic). They were ignored because the storage::new() call sets up its boot_services by calling StandardBootServices::new_uninit():
Eventually, actual calls are made to setup Ready to Boot and Exit Boot Services notifications:
However, the pointers still point to the uninitialized implementation and are not mocked. This issue tracks adding these tests back when UEFI Services tracked in https://github.com/OpenDevicePartnership/patina/issues/1537 are available to mock the event services.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the three ignored tests in patina/components/patina_test/src/component.rs and trace storage::new() through sdk/patina/src/component/storage.rs. Read the UEFI event-service setup in patina/components/patina_test/src/service.rs and issue #1537 for the required mocks. Done means the event services are mocked and the tests run successfully without being ignored.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- embedded-iot, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100