OpenDevicePartnership / OpenDevicePartnership/patina

[Feature]: make `v1_resource_descriptor_support` feature additive

Open
#1,663 1 comment 0 reactions 1 assignee View on GitHub

@Javagedes is already working on this.

Since Jul 29, 2026.

state:needs-maintainer-feedback type:feature-request urgency:medium
Dominant language
Rust
Stars
544
Forks
54
Avg merge
1d 8h
Merged PRs (30d)
30

Description

Feature Overview

The v1_resource_dscriptor_support feature currently swaps ResourceDescriptorV2 support for ResourceDescriptorV1 support. As the parent issue suggests, this goes against rust's rules that Features should be additive (as specified in Feature Unification.

Solution Overview

Paths to resolve this feature:

  1. If both HOBs can exist at the same time, then we should elect to always support ResourceDescritporV2 HOBs and the feature should only add support for parsing ResourceDescriptorV1 HOBs.

  2. Create a v2_resource_descriptor_support feature that is enabled by default and allow the platform to elect to enable one or the other (or both)

  3. If both HOBs cannot exist at the same time, then the feature should be completely removed, and a platform configuration should be added to decide which HOB to acknowledge.

Alternatives Considered

N/A

Urgency

Medium

Are you going to implement the feature request?

I will implement the feature

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

@os-d @makubacki for comments on solutions. I've provided three and amlooking for feedback.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.