OpenDevicePartnership / OpenDevicePartnership/odp-secure-services
Complete EC service stub implementations + unit tests
Open
@dymk is already working on this.
Since Apr 16, 2026.
- Dominant language
- Rust
- Stars
- 3
- Forks
- 11
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 5
Description
Overview\n\nComplete the stub service implementations in ec-service-lib with stateful logic, error handling, and comprehensive unit tests. Each service currently has a skeleton that returns hardcoded or NotSupported responses — these need to be filled in with real state-tracking behavior.\n\n## Services\n\n- [ ] Thermal — state-tracking for all 6 opcodes (get_temperature, set/get_threshold, set/get_variable, get_policy)\n- [ ] Battery — all 15 opcodes (BTP, BMC, BST, BIX, BPC, BPS, BCT, BCV, BAR, BAT_DIS, BAT_STA, BAT_PSR, BAT_SOC, BAT_CYC, BAT_FCC)\n- [ ] FwMgmt — error handling + process_indirect\n- [ ] Notify — add/remove/assign/unassign state-tracking\n- [ ] TPM — extended handlers (get_feature_info, register, unregister, finish, deinit)\n\n## Related PRs\n\n- #56 — Thermal\n- #57 — Battery\n- #58 — FwMgmt, Notify, TPM\n\n## Scope\n\nUnit tests for each service, plus MessageHandler dispatch tests. Fixes for any bugs found (e.g. panic on invalid MessageID, shift overflow in notify).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.