OpenDevicePartnership / OpenDevicePartnership/odp-platform-common

ec-test-cli: Remove `critical-section` dep when able

Open
#29 0 comments 0 reactions 1 assignee View on GitHub

@kurtjd is already working on this.

Since Apr 9, 2026.

enhancement
Dominant language
Rust
Stars
1
Forks
5
Avg merge
3d 4h
Merged PRs (30d)
9

Description

https://github.com/OpenDevicePartnership/odp-platform-common/pull/27 introduced the ec-test-cli and it also discovered a bug where debug builds won't build without a criticial-section implementation (it seemed to work in release build since the compiler could recognize critical-section related stuff as dead code).

This happens because the ec apps here depend on some of the service message dependencies, which transitively depend on embedded-services. embedded-services unconditionally pulls in the critical-section dep but requires the user to provide the critical section implementation.

Hence, in the above PR, I just used the std implementation. Should investigate if we can remove the embedded-services dep from all the deps we use here which will allow us to remove the ugly crtiical-section dep here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.