OpenDevicePartnership / OpenDevicePartnership/odp-platform-common
Move bench PR comment rendering into the bench tooling
@kat-perez is already working on this.
Since Sep 9, 2026.
- Dominant language
- Rust
- Stars
- 1
- Forks
- 5
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 9
Description
Move the benchmark comment rendering out of uefi-bench-pr-comment.yml and into the step that produces the results, so the comment workflow only downloads an artifact and posts it.
Why
The bencher output format is currently a contract between two places: whatever writes results-*.txt, and a sed/awk parser buried in workflow YAML. A format change breaks the second parser silently.
That script has also grown real logic — field sanitization, removed rows, unit-change detection — which belongs with the tool rather than the CI glue.
Raised by @rogurr in #209.
Acceptance criteria
- Bench step emits the rendered comment body (or a structured artifact) alongside the raw results
-
uefi-bench-pr-comment.ymlcontains no bencher-format parsing - Rendered comment is unchanged: base/head columns, within-spread labelling, and
new/removed/unit changedrows
Dependencies
- Depends on: #209
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.