OpenDevicePartnership / OpenDevicePartnership/embedded-services
battery-service: Re-export `embassy_time::Duration`
Open
@bjackson312006 is already working on this.
Since Jun 15, 2026.
- Dominant language
- Rust
- Stars
- 23
- Forks
- 53
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 13
Description
Description
The embassy_time::Duration type is exposed in battery-service's public API via get_timeout() and set_timeout() from controller.rs, but is not re-exported. This creates annoying dependency issues where, to implement the Controller trait, users of battery-service need to pull embassy-time into their project and hardcode it at the exact version battery-service uses.
Proposed Solution
In either controller.rs or lib.rs, add a pub use embassy_time::Duration; to re-export the type.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.